eaf8d7c677
PLAN §3 lists eight operators for M3 -- `$setOnInsert`, `$addToSet`, `$mul`,
`$min`, `$max`, `$pop`, `$pullAll`, `$currentDate` -- and the pinned crud
corpus says almost nothing about any of them. A probe running the identical
update against mongod 8.3.7 and this server found all eight answering
`bad update`, code 2, one message for every question.
It also found the thing this directory exists for: `$push`'s `$slice`,
`$position` and `$sort` are **silently ignored**. `{$each: [3, 4], $slice: -3}`
appends both values, slices nothing, and answers ok: 1 with modifiedCount: 1.
A missing operator is an error the client can see; a modifier that is parsed,
accepted and then dropped is the same class of wrong answer the positional
operators were.
103 cases in six files, 18 pass / 84 fail -- red by construction, like
`tests/spec/aggregate/expressions.json` at 1/26 and the positional corpus at
15/36. Inputs authored in `sources/`, every expectation measured.
Two things here cannot be recorded as values, and both become a `$$type`
assertion rather than being left out: a `$currentDate` field is whatever the
clock said (named per case in `volatile`, so a real stored date can still be
pinned one day), and an upsert that inserts gets a generated ObjectId (that
one automatic -- no source authors an ObjectId). Everything else is compared
exactly. Files are canonical extended JSON, which the runner already parses
that way: `$mul` overflowing an int32 produces an int64, and writing
`4000000000` as a bare number would not have said so.
What recording it settled, none of it guessable:
- `$mul` of a missing field writes **0**, not the operand; of a non-numeric
field, or by one, TypeMismatch (14).
- `$min`/`$max` are not numeric operators. They compare in BSON canonical
order, so `$min: {s: 5}` on `s: "b"` writes 5, and a missing field is
always written.
- two operators writing one field is **ConflictingUpdateOperators (40)** --
`$min`+`$max`, `$set`+`$inc`, `$setOnInsert`+`$set`. A whole error class
this server does not have.
- `$addToSet` compares documents whole, **field order included**:
`{a:1,b:2}` and `{b:2,a:1}` are two values. But `2` and `2.0` are one.
- `$push` modifiers are only modifiers when `$each` is there: `{$slice: 1}`
alone is a value to push. With it, the order is position, then sort the
whole array, then slice.
- `$currentDate` with `false` still writes a date.
- `$setOnInsert` may write `_id` on an insert, where `$set` may not.
- an unknown modifier is FailedToParse (9), not BadValue.
One case was authored and then removed: `{b: 1, $set: {c: 1}}` never reaches a
server -- the driver rejects it -- so there was no answer to record and the
case would have asserted nothing.
89 lines
3.2 KiB
JSON
89 lines
3.2 KiB
JSON
{
|
|
"_comment": [
|
|
"Inputs only. Expectations are measured -- see record.js.",
|
|
"The operator table itself, rather than any one operator: what an update",
|
|
"document may be, and what happens to a name that is not in the table.",
|
|
"This server answers `bad update` with code 2 to every one of these, which",
|
|
"is one message covering several different questions.",
|
|
"A `{b: 1, $set: {...}}` case was authored and then removed: the driver",
|
|
"rejects it before it reaches a server, so there is no server answer to",
|
|
"record and a case with no `errorCode` would assert nothing."
|
|
],
|
|
"documents": [{ "_id": 1, "a": 1, "t": [1, 2] }],
|
|
"cases": [
|
|
{
|
|
"description": "an unknown modifier",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$bogus": { "a": 1 } } }
|
|
},
|
|
{
|
|
"description": "an unknown modifier beside a known one",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$set": { "b": 1 }, "$bogus": { "a": 1 } } }
|
|
},
|
|
{
|
|
"description": "a known modifier whose argument is not a document",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$set": 1 } }
|
|
},
|
|
{
|
|
"description": "an empty argument to a known modifier",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$set": {} } }
|
|
},
|
|
{
|
|
"description": "a data field after an operator",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$set": { "c": 1 }, "b": 1 } }
|
|
},
|
|
{
|
|
"description": "two operators writing the same field",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$set": { "a": 2 }, "$inc": { "a": 1 } } }
|
|
},
|
|
{
|
|
"description": "$inc on a non-numeric field",
|
|
"documents": [{ "_id": 1, "a": "x" }],
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$inc": { "a": 1 } } }
|
|
},
|
|
{
|
|
"description": "$inc by a non-numeric operand",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$inc": { "a": "x" } } }
|
|
},
|
|
{
|
|
"description": "$push onto a non-array field",
|
|
"documents": [{ "_id": 1, "t": 5 }],
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$push": { "t": 1 } } }
|
|
},
|
|
{
|
|
"description": "$pull on a non-array field",
|
|
"documents": [{ "_id": 1, "t": 5 }],
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$pull": { "t": 1 } } }
|
|
},
|
|
{
|
|
"description": "$unset of a field that is not there",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$unset": { "gone": "" } } }
|
|
},
|
|
{
|
|
"description": "$rename onto a field that already exists",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$rename": { "a": "t" } } }
|
|
},
|
|
{
|
|
"description": "$rename of a field that is not there",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$rename": { "gone": "b" } } }
|
|
},
|
|
{
|
|
"description": "an update that writes nothing still reports a match",
|
|
"operation": "updateOne",
|
|
"arguments": { "filter": {}, "update": { "$set": { "a": 1 } } }
|
|
}
|
|
]
|
|
}
|