dev/MultiforaDB
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests/spec: a recorded corpus for the update operators

Browse Source 
PLAN §3 lists eight operators for M3 -- `$setOnInsert`, `$addToSet`, `$mul`,
`$min`, `$max`, `$pop`, `$pullAll`, `$currentDate` -- and the pinned crud
corpus says almost nothing about any of them. A probe running the identical
update against mongod 8.3.7 and this server found all eight answering
`bad update`, code 2, one message for every question.

It also found the thing this directory exists for: `$push`'s `$slice`,
`$position` and `$sort` are **silently ignored**. `{$each: [3, 4], $slice: -3}`
appends both values, slices nothing, and answers ok: 1 with modifiedCount: 1.
A missing operator is an error the client can see; a modifier that is parsed,
accepted and then dropped is the same class of wrong answer the positional
operators were.

103 cases in six files, 18 pass / 84 fail -- red by construction, like
`tests/spec/aggregate/expressions.json` at 1/26 and the positional corpus at
15/36. Inputs authored in `sources/`, every expectation measured.

Two things here cannot be recorded as values, and both become a `$$type`
assertion rather than being left out: a `$currentDate` field is whatever the
clock said (named per case in `volatile`, so a real stored date can still be
pinned one day), and an upsert that inserts gets a generated ObjectId (that
one automatic -- no source authors an ObjectId). Everything else is compared
exactly. Files are canonical extended JSON, which the runner already parses
that way: `$mul` overflowing an int32 produces an int64, and writing
`4000000000` as a bare number would not have said so.

What recording it settled, none of it guessable:

  - `$mul` of a missing field writes **0**, not the operand; of a non-numeric
    field, or by one, TypeMismatch (14).
  - `$min`/`$max` are not numeric operators. They compare in BSON canonical
    order, so `$min: {s: 5}` on `s: "b"` writes 5, and a missing field is
    always written.
  - two operators writing one field is **ConflictingUpdateOperators (40)** --
    `$min`+`$max`, `$set`+`$inc`, `$setOnInsert`+`$set`. A whole error class
    this server does not have.
  - `$addToSet` compares documents whole, **field order included**:
    `{a:1,b:2}` and `{b:2,a:1}` are two values. But `2` and `2.0` are one.
  - `$push` modifiers are only modifiers when `$each` is there: `{$slice: 1}`
    alone is a value to push. With it, the order is position, then sort the
    whole array, then slice.
  - `$currentDate` with `false` still writes a date.
  - `$setOnInsert` may write `_id` on an insert, where `$set` may not.
  - an unknown modifier is FailedToParse (9), not BadValue.

One case was authored and then removed: `{b: 1, $set: {c: 1}}` never reaches a
server -- the driver rejects it -- so there was no answer to record and the
case would have asserted nothing.
This commit is contained in:
A.Shakhmatov
2026-08-10 21:02:51 +03:00
parent 1482df891b
commit eaf8d7c677
15 changed files with 999 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

153
tests/spec/operators/sources/array-ops.json Normal file
View File

@@ -0,0 +1,153 @@
{
"_comment": [
"Inputs only. Expectations are measured -- see record.js.",
"`$addToSet`, `$pop` and `$pullAll`: the three array operators that are",
"neither `$push` nor `$pull`. Each has a shape that decides whether it",
"wrote at all -- a set that already held the value, a pop of an empty",
"array, a pullAll matching nothing -- and `modifiedCount` is the only",
"place that shows, which is why every case records an outcome too."
],
"documents": [{ "_id": 1, "t": [1, 2, 3] }],
"cases": [
{
"description": "$addToSet appends a value the array does not hold",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "t": 4 } } }
},
{
"description": "$addToSet on a value already there writes nothing",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "t": 2 } } }
},
{
"description": "$addToSet on a missing field creates the array",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "gone": 1 } } }
},
{
"description": "$addToSet $each adds only what is missing",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "t": { "$each": [2, 4, 5] } } } }
},
{
"description": "$addToSet $each with duplicates inside it",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "t": { "$each": [7, 7] } } } }
},
{
"description": "$addToSet compares documents whole",
"documents": [{ "_id": 1, "t": [{ "a": 1 }] }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "t": { "a": 1 } } } }
},
{
"description": "$addToSet distinguishes documents by field order",
"documents": [{ "_id": 1, "t": [{ "a": 1, "b": 2 }] }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "t": { "b": 2, "a": 1 } } } }
},
{
"description": "$addToSet treats an int and an equal double as one value",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "t": 2.0 } } }
},
{
"description": "$addToSet on a non-array field",
"documents": [{ "_id": 1, "t": 5 }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "t": 1 } } }
},
{
"description": "$pop removes the last element",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "t": 1 } } }
},
{
"description": "$pop with -1 removes the first",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "t": -1 } } }
},
{
"description": "$pop of an empty array writes nothing",
"documents": [{ "_id": 1, "t": [] }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "t": 1 } } }
},
{
"description": "$pop of a missing field writes nothing",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "gone": 1 } } }
},
{
"description": "$pop of a one-element array leaves an empty one",
"documents": [{ "_id": 1, "t": [9] }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "t": 1 } } }
},
{
"description": "$pop with an argument that is neither 1 nor -1",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "t": 2 } } }
},
{
"description": "$pop with 1.0, which is 1",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "t": 1.0 } } }
},
{
"description": "$pop of a non-array field",
"documents": [{ "_id": 1, "t": 5 }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "t": 1 } } }
},
{
"description": "$pullAll removes every copy of every listed value",
"documents": [{ "_id": 1, "t": [1, 2, 3, 2] }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pullAll": { "t": [2] } } }
},
{
"description": "$pullAll with several values",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pullAll": { "t": [1, 3] } } }
},
{
"description": "$pullAll matching nothing writes nothing",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pullAll": { "t": [9] } } }
},
{
"description": "$pullAll compares documents whole, not by predicate",
"documents": [{ "_id": 1, "t": [{ "a": 1 }, { "a": 2 }] }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pullAll": { "t": [{ "a": 1 }] } } }
},
{
"description": "$pullAll on a missing field writes nothing",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pullAll": { "gone": [1] } } }
},
{
"description": "$pullAll with an argument that is not an array",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pullAll": { "t": 1 } } }
},
{
"description": "$pullAll emptying the array",
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pullAll": { "t": [1, 2, 3] } } }
},
{
"description": "$addToSet through a positional segment",
"documents": [{ "_id": 1, "y": [{ "t": [1] }, { "t": [2] }] }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$addToSet": { "y.$[].t": 1 } } }
},
{
"description": "$pop down a dotted path",
"documents": [{ "_id": 1, "n": { "t": [1, 2] } }],
"operation": "updateOne",
"arguments": { "filter": {}, "update": { "$pop": { "n.t": -1 } } }
}
]
}